fix(2P): rewrite MIP constraint to respect relative range limits #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
fix/add-back-relative-range-limitations-for-2P
branch
2 times, most recently
from
884d600 to
769732d
Compare
MartinBelthle
changed the title
pet-mit
added
next-release
pet-mit
requested changes
Jul 12, 2024
.../resources/com/powsybl/openrao/tests/features/epic19_specific_rao_parameters/US19_11.feature
Outdated
Show resolved
Hide resolved
...bl/openrao/searchtreerao/linearoptimisation/algorithms/fillers/DiscretePstTapFillerTest.java
Show resolved
Hide resolved
...bl/openrao/searchtreerao/linearoptimisation/algorithms/fillers/DiscretePstTapFillerTest.java
Show resolved
Hide resolved
...nrao/searchtreerao/linearoptimisation/algorithms/linearproblem/LinearProblemIdGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: belthlemar <[email protected]>
MartinBelthle
force-pushed
the
fix/add-back-relative-range-limitations-for-2P
branch
from
5104576 to
018b978
Compare
pet-mit
approved these changes
Jul 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Due to the recently merged PR #1070, the relative ranges for PST in 2P Global Optimization (when modeled as APPROXIMATED_INTEGERS) were no longer respected.
This made the test 19.11.9.bis fail when ran with XPRESS.
What is the new behavior (if this is a feature change)?
I've changed the MIP equation and now they are.
Does this PR introduce a breaking change or deprecate an API?